Hi @fjuma, do we want to add this file in https://github.com/wildfly-security-incubator/elytron-examples/tree/main/simple-webapp-oidc ?

Hi @theashiot, apologies for the delayed response. I haven't gone through this in detail yet but yes, adding a file with the required configuration for k8s to the existing example would make sense.

Thanks, @fjuma, i've created a PR to add the file: wildfly-security-incubator/elytron-examples#209

I'll updated the steps shortly.

I've updates the steps. Ready for review!

Please note that I haven't tested the steps for Quay. I have based them on https://www.wildfly.org/news/2023/06/16/deploy-on-kubernetes-with-helm/ . I'm facing some authentication problems with Quay.

I've tested the steps for Docker Hub.

FYI, the examples repo is under the wildfly-security-incubator account.
https://github.com/wildfly-security-incubator/elytron-examples

thanks, fixed!

s/on Kubernetes cluster/on a Kubernetes cluster

s/OIDC provider/OpenID provider

Fixed!

s/OIDC identity provider/OpenID provider

fixed

s/till/up until

updated

CONTAINER_REGISTRY seems to render a bit odd. Could we use <CONTAINER_REGISTRY> or something similar instead?

updated all italics to <this_form>

Same here, renders in a way that's a bit hard to read.

done

Please uncomment this to have the table of contents appear at the top of the guide.

done

Please update the first link to https://github.com/wildfly-security-incubator/elytron-examples/blob/main/simple-webapp-oidc/src/main/java/org/wildfly/security/examples/SecuredServlet.java

fixed

This could be reworded to "... documentation on how to Manage OpenID Connect clients" or "... documentation on Managing OpenID Connect clients"

used the latter, thanks

It might be clearer to say "Navigate to the simple-webapp-oidc directory."

agreed, updated

s/wildfly-security/wildfly-security-incubator

fixed

You can update the version number to 33 to keep it up to date

done

This installation guide has 2 sets of directions, one with the "Ingress addon"
and one without. You need to instruct the user whether this example requires
the "Ingress addon". Direct the user as to which set of instructions to use
as it relates to Ingress.

added a line "This guide uses Keycloak with Ingress add-on enabled."

Tell the user that during this step, "make note of the
initial admin user username, password and Keycloak Admin Console URL",
as it will be needed in the next step.

done

The directions linked to are old and not that helpful. Use this link and
instruct the user to Follow the directions in "Creating a realm".
https://www.keycloak.org/docs/latest/server_admin/#proc-creating-a-realm_server_administration_guide

updated

The directions linked to are old and not that helpful. Use this link and
instruct the user to Follow the directions in "Creating a realm role",
following steps 1,2 and 4. Step 3 is optional
https://www.keycloak.org/docs/latest/server_admin/#proc-creating-realm-roles_server_administration_guide

updated.

Remove this direction. If the user performed all the tasks listed for "create a user" they will have set the password already.

Updated the link here to be consistent with the others. This one doesn't contain steps for adding a password, so added a sub-step.

Don't make this a separate numbered step. Make it the 2nd paragraph of step 4. create user, because this task (e.g. tab) is accessed from the user details page.

Made this a sub step.

These directions are more concise and clear

Click the General Settings image in the top left hand corner of the admin console
Click the "Clients" menu item
Click the "Create client" button
On the "Create client" page set the "Client type" to "OpenID Connect".
Set the "Client id" as, myclient.
Click the "Next" button at the bottom of the page
On the "Capability config" page the checkboxes for "Standard flow"
and "Direct access grants" should be selected.
Click the "Next" button at the bottom of the page
On the "Login settings" page no action is needed at this time.
Click the "Save" button at the bottom of the page.

agreed, updated with slight modifications.

I would remove this reference. It just confuses the whole situation because it does not accurately reflect the current screen layout.

removed

Remove this step. The image was verified in the previous section. There is no reason to re-verify it here.

done

Remove the reference to wildfly-maven-plugin here. It is distracting from the current task and you discuss it at a more appropriate time in a future section.

done

These directions are more concise and clear

Click the General Settings image in the top left hand corner of the admin console
Click the "Clients" menu item
Click on "myclient" from the list on the Clients page.
Scroll down to the "Access settings" section on the page.
In field, "Valid redirect URIs set the value to http://localhost:8080/simple-webapp-oidc/secured/pass:[*]
Click the "Save" button at the bottom of the page.

agreed, updated with slight modification.